iTowns / itowns

A Three.js-based framework written in Javascript/WebGL for visualizing 3D geospatial data
http://www.itowns-project.org
Other
1.09k stars 293 forks source link

fix example Gpx 3d and functional test #2187

Closed ftoromanoff closed 11 months ago

ftoromanoff commented 12 months ago

There is a bug on the source_file_gpx_3d.html example:

As the functional test wasn't well design (we only test that the view is initialized even if the example add extra layer after that), it create error in the github action from time to time. I change the functionnal test to see if the example is fully loaded and corrected in the example the source of the error.

The error is linked to the fact that a style.fill is needed (at least in parent.style) when we instanciate a new Style: https://github.com/iTowns/itowns/blob/e56bf65c29189b86b87f8b1a9b1bce2f451ff517/src/Core/Style.js#L508 and the way we set the getter: https://github.com/iTowns/itowns/blob/e56bf65c29189b86b87f8b1a9b1bce2f451ff517/src/Core/Style.js#L144 Or in this example the style is defined during the parsing.

This issue is solve in the PR #2135 as we remove the need for a fill.patern and in PR #2006 as we remove the definition of parent Style.