Currently there are multiple ways to set the position and scale properties of point cloud meshes when fetching and parsing data. This leads to hard-coded condition in the provider mechanism (see PointCloudProvider.js). We may want to provide and document a unique way for all pointcloud layers.
Actual Behavior
The Potree layer set the position and apply scaling after parsing using the bbox.min property of the PotreeNode and scale property of the PotreeLayer.
Both the Enwtine and the future COPC layers apply the scaling and translation at parsing, a hard-coded guard disable the scaling and positionning after parsing.
Expected Behavior
A few suggestions:
We could set layer.scale at Vector(1.0, 1.0, 1.0) for both Entwine and COPC layers.
We could move the offset property to the layer, use metadata properties for PotreeLayer and set it at Vector(0.0, 0.0, 0.0) for both Entwine and COPC layer.
Context
Currently there are multiple ways to set the position and scale properties of point cloud meshes when fetching and parsing data. This leads to hard-coded condition in the provider mechanism (see
PointCloudProvider.js). We may want to provide and document a unique way for all pointcloud layers.Actual Behavior
bbox.minproperty of thePotreeNodeandscaleproperty of thePotreeLayer.Expected Behavior
A few suggestions:
layer.scaleatVector(1.0, 1.0, 1.0)for both Entwine and COPC layers.offsetproperty to the layer, use metadata properties forPotreeLayerand set it atVector(0.0, 0.0, 0.0)for both Entwine and COPC layer.