search

iTowns / itowns

A Three.js-based framework written in Javascript/WebGL for visualizing 3D geospatial data
http://www.itowns-project.org
Other
1.08k stars 293 forks source link

Fix `C3DTilesLayer` and `C3DTFeature` #2222

Closed valentinMachado closed 8 months ago

valentinMachado commented 8 months ago

Description

C3DTFeature reference the THREE.Object3D where they belong. computeWorldBox3 is now a method of C3DTFeature possible due to the latter modification Some code clean. updateStyle is call after dispacthing event ON_TILE_CONTENT_LOADED

Motivation and Context

C3DTFeature reference the THREE.Object3D where they belong. => tileContent can have different child with feature in it which was not handle by the previous code updateStyle is call after dispacthing event ON_TILE_CONTENT_LOADED => when listener of this event influences C3DTilesLayer style the user does not have to call an extra updateStyle of the layer

waiting this to be approved to rename commits name

valentinMachado commented 8 months ago

Great ! I've made a single commit, and CI is working.