iTowns / itowns

A Three.js-based framework written in Javascript/WebGL for visualizing 3D geospatial data
http://www.itowns-project.org
Other
1.08k stars 293 forks source link

chore(deps): December 2023 bump #2234

Closed Desplandis closed 7 months ago

Desplandis commented 7 months ago

Description

Update all dependencies (when possible). I listed one major issue due to license change as well as minor issues questioning the necessity of certain dependencies or packaging problems upstream.

Peer dependencies

@mgermerie @jailln Since peer dependencies tie users of the library to those versions, shall we tag the commits as features?

Dependencies

Those are the packages with a new version available:

Those packages may not be needed anymore:

Developer dependencies

Those packages upgrades introduce no breaking change:

Those packages upgrades introduce a breaking change for our use-cases:

This package introduces coverage regression and will not be updated:

Notes to reviewer

I didn't had access to pre-1.0 3D Tiles files to test lighting issues and edits to LegacyGLTFLoader. Maybe @jailln you could test it on your proprietary datasets ?

mgermerie commented 7 months ago

@mgermerie @jailln Since peer dependencies tie users of the library to those versions, shall we tag the commits as features?

I think this is a good idea. Bumping them sometimes grants users with new features introduced in their new versions. On another point, I often pay more attention to the "feature" section of a changelog than the "workflows and chores" (or equivalent name). So based on my own experience, it would make peer dependencies update more visible. However this has yet to be confirmed by other user experiences.

Desplandis commented 7 months ago

@jailln @mgermerie Ready for review, I added a "Notes to reviewer" to my initial message. Unfortunately, I dont't have access to 3D Tiles with old gltfs (version = 1.0).

mgermerie commented 7 months ago

I also think we could remove regenerator-runtime and text-encoding-utf-8 - perhaps in a future PR ?

Desplandis commented 7 months ago

Opened an issue for mapbox and a PR for removing unecessary dependencies. Will now merge this PR.