Fix pointcloud node subdivision for orthographic projections

iTowns / itowns

A Three.js-based framework written in Javascript/WebGL for visualizing 3D geospatial data

http://www.itowns-project.org

Other

1.08k stars 293 forks source link

Fix pointcloud node subdivision for orthographic projections #2242

Closed Desplandis closed 7 months ago

Desplandis commented 7 months ago

Description

For now, point cloud layer's screen-space error (SSE) calculation is only valid for perspective cameras. This causes issues when using an orthographic camera (e.g. #2232: point cloud not updating).

This PR fixes two issues:

do not compute point attenuation when using an orthographic projection
add a new way to compute SSE when using an orthographic projection

Related issues

closes #2232

Desplandis commented 7 months ago

@Pourfex Does rebasing/cherry-picking on this PR fix your issue?

Pourfex commented 7 months ago

@Pourfex Does rebasing/cherry-picking on this PR fix your issue?

Perfect ! Work like a charm. Thanks for your quick resolve