[BUG] Unit tests issues with node latest published version (21.5.0) - Githubissues

iTowns / itowns

A Three.js-based framework written in Javascript/WebGL for visualizing 3D geospatial data

http://www.itowns-project.org

Other

1.07k stars 290 forks source link

[BUG] Unit tests issues with node latest published version (21.5.0) #2254

Open mgermerie opened 6 months ago

mgermerie commented 6 months ago

Your Environment

Version used: 2.41.0
Node version: 21.5.0 (latest published version)
npm version: 10.2.4

Context

Trying to run unit tests on Node current version (21.5.0) brings warnings and errors :

In test/unit/bootstrap.js, line 26, we set navigator.userAgent property which has been made read-only in node 21.1.0 (see this commit. This can be easily fixed with a test :
```
if (!global.navigator) {
global.navigator = { userAgent: 'firefox' }
}
```

When applying the previous fix, we get a deprecation warning :

(node:29868) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.

Steps to Reproduce (for bugs)

Download and use node 21.1.0
run npm install
run npm run test-unit
You can see the deprecation message after applying the fix in #

Possible Cause/Fix/Solution

The first point is fixed in #2255.

Desplandis commented 6 months ago

Can confirm that this issue starts with node >= 21.0.0, latest LTS (20.x.x) is not impacted.