iTowns / itowns

A Three.js-based framework written in Javascript/WebGL for visualizing 3D geospatial data
http://www.itowns-project.org
Other
1.07k stars 291 forks source link

feat(TileLayer): add hide skirt parameter #2280

Closed AnthonyGlt closed 4 months ago

AnthonyGlt commented 4 months ago

Description

Add a new parameter "hideSkirt" to the layer to hide the skirt (borders of tiles).

To test, the parameter can be updated like this -> view.tileLayer.hideSkirt = true;

Motivation and Context

Useful when the opacity < 1

Screenshots (if appropriate)

With hideSkirt = false (current default behavior) Screenshot from 2024-02-26 11-31-24

with hideSkirt = true Screenshot from 2024-02-26 11-31-27

Important

If merged, it's necessary to update the doc to describe this parameter and how to use it

jailln commented 4 months ago

I think we should hide it by default when changing the opacity of the layer to always avoid the effect you show in the first screenshot; WDYT @AnthonyGlt @Desplandis ?

AnthonyGlt commented 4 months ago

if we hide it, we see through the terrain , cf screen shot below.

To correct this, it's necessary to switch the scene background color to black and disable the atmosphere

Screenshot from 2024-02-26 14-08-03

jailln commented 4 months ago

I meant hide it only when the opacity is < 1

AnthonyGlt commented 4 months ago

the result will be nice when we don't zoom but when we zoom, we'll see the background color (like the screenshot above), can be a trade off.

jailln commented 4 months ago

the result will be nice when we don't zoom but when we zoom, we'll see the background color (like the screenshot above), can be a trade off.

Yes you're right, I'm not sure what's best so let's leave it like this for now

AnthonyGlt commented 4 months ago

Linked proposal for future development of underground visualization https://github.com/iTowns/itowns/issues/2281