doc(tutorials): minor typo and syntax fixes

iTowns / itowns

A Three.js-based framework written in Javascript/WebGL for visualizing 3D geospatial data

http://www.itowns-project.org

Other

1.07k stars 291 forks source link

doc(tutorials): minor typo and syntax fixes #2285

Closed HoloTheDrunk closed 4 months ago

HoloTheDrunk commented 4 months ago

Description

Multiple minor fixes to tutorials.

Motivation and Context

Better documentation.

HoloTheDrunk commented 4 months ago

After investigating it seems like the tests either couldn't load the required examples files (seems unlikely unless the webpack config was changed recently) or one of the tests timing out simply stopped the entire run and forcefully failed the other tests with incorrect error states. The codebase is still largely unknown to me, do you have another explanation for the fails?

jailln commented 4 months ago

Yes that's it, it has been fixed just now in #2286, you just need to rebase.

Desplandis commented 4 months ago

@HoloTheDrunk Seems to be because we were still using pre-geoplateforme URIs for our vector tiles examples. Seems that #2286 fixes this ! I will relaunch the CI. =)

HoloTheDrunk commented 4 months ago

~~:warning: Don't merge this just yet, the use of the C3DTILES_LAYER_EVENTS.ON_TILE_CONTENT_LOADED is invalid.~~ Resolved.