fix(PointCloud): correct some issues after refacto #2262

iTowns / itowns

A Three.js-based framework written in Javascript/WebGL for visualizing 3D geospatial data

http://www.itowns-project.org

Other

1.06k stars 290 forks source link

fix(PointCloud): correct some issues after refacto #2262 #2316

Closed AnthonyGlt closed 2 months ago

AnthonyGlt commented 3 months ago

Description

Correct some issues links to the merge #2262

Motivation and Context

After the merge, there is spam of warnings in the console. Also the classification wasn't showing anymore in the example view_3d_map.html

Screenshots

Screenshot from 2024-03-28 18-00-34

Screenshot from 2024-03-28 17-50-31

AnthonyGlt commented 3 months ago

Maybe we could rename classification to classificationScheme in the layer options

Desplandis commented 3 months ago

@AnthonyGlt Seems that our testing is not efficient to detect such issues. Could you add a unit and/or functional test in this PR to detect similar issues on 3DTiles point clouds?

airnez commented 2 months ago

Please also update this comment https://github.com/iTowns/itowns/blob/f3f8a0a5387a4905a742a0c89a3e8aaba7278d8b/src/Layer/C3DTilesLayer.js#L98

AnthonyGlt commented 2 months ago

Also remove ; in https://github.com/iTowns/itowns/blob/f3f8a0a5387a4905a742a0c89a3e8aaba7278d8b/src/Renderer/PointsMaterial.js#L72