iTowns / itowns

A Three.js-based framework written in Javascript/WebGL for visualizing 3D geospatial data
http://www.itowns-project.org
Other
1.07k stars 290 forks source link

fix(C3DTFeature): use correct interleaved buffer getter #2326

Open AnthonyGlt opened 2 months ago

AnthonyGlt commented 2 months ago

Description

We should use the getter of threejs to access position in buffer, especially when we have interleaved buffer

Motivation and Context

Similar to what was done in https://github.com/iTowns/itowns/pull/2266

To note: I encountered issues related to the batchtable, I wonder if there is some misconception in the treatment of it. I will try to investigate more

AnthonyGlt commented 1 month ago

@Desplandis I assign it to you but maybe someone else could be more fitted to this MR. To whoever review this MR, could you please test it, because I could be the one making a misconception here, thank you :)