chore(deps): June 2024 bump

Desplandis commented 2 weeks ago

Description

Update all dependencies (when possible). A lot of dependencies now mandates node >= 18.0.0, shall we mark this as breaking changes?

Previous major bump in #2234

Those are the packages with a new version available:

[x] @mapbox/mapbox-gl-style-spec (13.28.0): Still the same problems as #2234. Will not update due to the fact this is the latest version with a FOSS license (ISC). This is a huge red-flag, shall we consider moving to @maplibre/maplibre-gl-style-spec @iTowns/reviewers?
[x] shpjs (4.0.4 to 5.0.1): Distributes as ESM now. No issue since we already migrated to ESM.
[x] @tweenjs/tween.js (18.6.4 to 23.1.2): Distributes as ESM now. A few breaking changes which does not impact us.

Those packages upgrades introduce no breaking change:

[x] @babel/cli, @babel/core and the following plug-ins: @babel/plugin-transform-runtime and @babel/preset-env.
[x] c8.
[x] chart.js.
[ ] conventional-changelog-cli: Pure ESM package, issues with our CJS script.
[x] core-js.
[ ] eslint and the following plug-in: eslint-plugin-import: cannot update to ESLint 9 since the plugin requires ESLint8.
[x] https-proxy-agent.
[x] jsdoc.
[x] marked: unused, remove (added in https://github.com/iTowns/itowns/pull/612)
[ ] mocha: update cause deprecation notice of glob dependency.
[ ] node-fetch: Can update to 3.x.x since we are now a ESM only package. TypeError with fetcher.js test. Note that node 18 support natively the fetch API.
[x] puppeteer.
[x] replace-in-file.
[x] sinon.
[x] typescript.
[x] webpack and the following plugin: webpack-dev-server and eslint-webpack-plugin.

mgermerie commented 1 week ago

Thanks for the updates. Here are a few answers to the points you mention :

If we change the minimal node version supported, I think we should mark it as a breaking change.
I also agree we should look at what @maplibre/maplibre-gl-style-spec does and aim to use it instead of @mapbox.
Do you intend to fix issues with package you didn't update in this PR or should we do it in another PR and merge this one as is ?

Desplandis commented 1 week ago

Thanks @mgermerie for your review!

If we change the minimal node version supported, I think we should mark it as a breaking change.

Noted, I'll do it. Note that this does not impact downstream users (only developer of the itowns repo).

I also agree we should look at what @maplibre/maplibre-gl-style-spec does and aim to use it instead of @mapbox.

Shall I open an issue or shall we discuss this on our next dev meeting?

Do you intend to fix issues with package you didn't update in this PR or should we do it in another PR and merge this one as is ?

As you wish, I could fix them in this PR and not report the fixes in 2/3 years x)