iTowns / itowns

A Three.js-based framework written in Javascript/WebGL for visualizing 3D geospatial data
http://www.itowns-project.org
Other
1.07k stars 290 forks source link

fix(pointcloud): fix non-world projected elevation #2346

Closed Desplandis closed 1 week ago

Desplandis commented 1 week ago

Before contributing

Read CONTRIBUTING.md and CODING.md to apply iTowns conventions on PRs, Git history and code.

Description

This PR fixes an issue with the elevation color on our points material. The elevation (z component of the position attribute) was not projected in the world space, and used in a gradient where min and max were in world space. Two pictures are worth a thousand words (before/after this PR):

Screenshot 2024-06-24 at 16-03-43 Itowns Examples Screenshot 2024-06-24 at 16-03-04 Itowns Examples