search

iTowns / itowns

A Three.js-based framework written in Javascript/WebGL for visualizing 3D geospatial data
http://www.itowns-project.org
Other
1.1k stars 298 forks source link

Timeout in unit test potree 2 #2353

Open gchoqueux opened 3 months ago

gchoqueux commented 3 months ago

There's time out in unit test potree 2

https://github.com/iTowns/itowns/actions/runs/9791693583/job/27036065634

proposal

Increase the timeout mocha --timeout 5000

jailln commented 3 months ago

What is the timeout related to? Is it related to files taking too long to load/loading too much files? Is it related to the server? I'm wondering if we should increase the timeout or consider changing the test file.

By the way, if we keep this test file, we should consider storing the test dataset on itowns-sample-data-2, would that be feasible?

@Desplandis @ketourneau

ketourneau commented 3 months ago

Hi the test file is already in itowns-sample-data-2.

I created a PR to update sample data url : https://github.com/iTowns/itowns/pull/2354.

I hope it will solve the test timeout

ketourneau commented 3 months ago

I launched 20x potree2 test and I only got one time the timeout. The average test time is 540 ms so I don't think increasing the timeout will solve the problem. I'll keep investigating.

gchoqueux commented 2 months ago

time out in unit test https://github.com/iTowns/itowns/actions/runs/10092010021/job/27904819707#step:5:765