iTowns / itowns

A Three.js-based framework written in Javascript/WebGL for visualizing 3D geospatial data
http://www.itowns-project.org
Other
1.1k stars 298 forks source link

3d Tiles example is broken #727

Closed mbredif closed 6 years ago

mbredif commented 6 years ago

Your Environment

Current master : commit c091b0d9532a97fc62c567121983ceee433b26f7

Context

3d tiles example : http://www.itowns-project.org/itowns/examples/3dtiles.htm

Steps to Reproduce (for bugs)

  1. visit http://www.itowns-project.org/itowns/examples/3dtiles.html
  2. zoom in

Expected Behavior

It works with no error logging

Actual Behavior

The examples trigger many errors in the console.

Possible Cause/Fix/Solution

zarov commented 6 years ago

Sorry about this !

many Orthoimagery related errors are triggered

Concerning this, it is caused by the fact that the boundaries of Ortho here (in the US, where the 3D tiles are) are badly defined: it has nothing to load, as details are present in France only. This error was present before my commit, and is present in a lot of samples.

Otherwise the fixes of @peppsac seems to fix the second issue. I'll let you close this when you confirmed the fix.