iTowns / itowns

A Three.js-based framework written in Javascript/WebGL for visualizing 3D geospatial data
http://www.itowns-project.org
Other
1.09k stars 296 forks source link

Clearly separate Controls, Camera and CameraUtils #945

Open jailln opened 5 years ago

jailln commented 5 years ago

Controls, Camera and CameraUtils are not clearly separated and share some responsabilities. Some GlobeControls methods (such as getCameraCoordinate(), getCameraOrientation(), getCameraTargetGeoPosition(), getCameraTargetPosition(), etc.) are for instance related to the camera.

We should clearly separate these classes with the following responsabilities:

gchoqueux commented 5 years ago

Yes indeed, this needs to be clarified. We think to move these methods in the viewer or camera. But before we want only one Viewer (instead of PlanarViewer, GlobeViewer, PanoramaViewer and Viewer) and refactor the Controls.