search

iTrooz / efivar-rs

EFI boot manager tool written in Rust
MIT License
22 stars 7 forks source link

chore(efivar): fix clippy warnings #45

Closed iTrooz closed 1 year ago

iTrooz commented 1 year ago

For some reason, these warnings are not shown by cargo clippy in this project, but are highlighted by vscode, maybe that's why they went undetected ?

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 66.66% and project coverage change: -0.49 :warning:

Comparison is base (eb1aa50) 47.80% compared to head (93dc969) 47.31%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #45 +/- ## ========================================== - Coverage 47.80% 47.31% -0.49% ========================================== Files 19 19 Lines 864 856 -8 ========================================== - Hits 413 405 -8 Misses 451 451 ``` | [Impacted Files](https://app.codecov.io/gh/vtavernier/efiboot-rs/pull/45?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Vincent+Tavernier) | Coverage Δ | | |---|---|---| | [efivar/src/lib.rs](https://app.codecov.io/gh/vtavernier/efiboot-rs/pull/45?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Vincent+Tavernier#diff-ZWZpdmFyL3NyYy9saWIucnM=) | `89.74% <ø> (ø)` | | | [efivar/src/sys/linux.rs](https://app.codecov.io/gh/vtavernier/efiboot-rs/pull/45?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Vincent+Tavernier#diff-ZWZpdmFyL3NyYy9zeXMvbGludXgucnM=) | `61.53% <0.00%> (ø)` | | | [efivar/src/store/memory.rs](https://app.codecov.io/gh/vtavernier/efiboot-rs/pull/45?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Vincent+Tavernier#diff-ZWZpdmFyL3NyYy9zdG9yZS9tZW1vcnkucnM=) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

alixinne commented 1 year ago

For some reason, these warnings are not shown by cargo clippy in this project, but are highlighted by vscode, maybe that's why they went undetected ?

The version of the Rust toolchain is pinned in the project, cf. https://github.com/vtavernier/efiboot-rs/blob/master/rust-toolchain.toml#L2. This makes it so the CI doesn't randomly break when new versions of clippy come out with new checks. Usually the VS Code plugin uses the latest rust-analyzer and I'd assume the latest version of clippy, hence the extra warnings.

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 1.1.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: