search

iTrooz / efivar-rs

EFI boot manager tool written in Rust
MIT License
22 stars 7 forks source link

CI does not check Cargo.lock consistency #81

Closed MOZGIII closed 4 months ago

MOZGIII commented 5 months ago

See title, and Cargo.lock is not up to date, and gets dirty on cargo check

iTrooz commented 4 months ago

Not sure what you mean, I just ran cargo check and Cargo.lock didn't change And how would you go about checking its consistency in the CI ?

MOZGIII commented 4 months ago

It did for me, super odd.

But you should still all the relevant flags to CI: --frozen-lockfile I beleive it is

MOZGIII commented 4 months ago

diff.patch

iTrooz commented 4 months ago

Please ignore my last (now deleted) message

I found out why I didn't get the diffs: I wasn't using the latest commits (more specifically I didn't pull https://github.com/iTrooz/efivar-rs/commit/2a9e699ee22af1c71a870331e75722f363550b33)

I added the --frozen flag to the CI, and fixed Cargo.lock. Everything should work fine now.

Thanks for reporting this !

iTrooz commented 4 months ago

https://github.com/iTrooz/efivar-rs/commit/d63ed605bc66d2aab9c3dcb26b06f904dbb43249#commitcomment-141447546