search

iTwin / appui

Monorepo for iTwin.js AppUi
MIT License
9 stars 2 forks source link

Fix overflow issue in status bar overflow (backport #1093) #1104

Closed mergify[bot] closed 2 weeks ago

mergify[bot] commented 2 weeks ago

Changes

This PR fixes #1080 by ignoring overflown item size changes to fix the maximum update depth error. Additionally, the status bar will use the same overflow logic used by tool settings and widget tabs.

Testing

N/A

This is an automatic backport of pull request #1093 done by Mergify.

mergify[bot] commented 2 weeks ago

Cherry-pick of 44a9a4c9a844290d4e2405280018183a834f3a4d has failed:

On branch mergify/bp/release/5.0.x/pr-1093
Your branch is up to date with 'origin/release/5.0.x'.

You are currently cherry-picking commit 44a9a4c9a.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
    new file:   common/changes/@itwin/appui-react/fix-overflow_2024-10-31-14-00.json
    modified:   ui/appui-react/src/appui-react/layout/tool-settings/Docked.tsx
    modified:   ui/appui-react/src/appui-react/layout/widget/Tabs.tsx
    modified:   ui/appui-react/src/appui-react/statusbar/StatusBarComposer.tsx

Unmerged paths:
  (use "git add <file>..." to mark resolution)
    both modified:   common/config/rush/pnpm-lock.yaml

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally