search

iTwin / appui

Monorepo for iTwin.js AppUi
MIT License
8 stars 2 forks source link

Inconsistent SCSS File Formatting #331

Closed GerardasB closed 1 year ago

GerardasB commented 1 year ago

Describe the bug

The SCSS file formatting in our project is inconsistent, leading to difficulties in maintaining a clean and organized codebase. Furthermore, this is adding additional overhead when reviewing PRs with formatting-only changes.

There seems to be inadequate space around selectors, making the code less readable. Currently, there are 83 search hits for >. and 215 search hits for > . in *.scss files.

Expected behavior

SCSS files are well-formatted and consistent.

GerardasB commented 1 year ago

There is a VSCode setting scss.format.spaceAroundSelectorSeparator to address the spacing around selectors.

FlyersPh9 commented 1 year ago

What is the reasoning for devDependencies being set in each package rather than in the root? https://github.com/iTwin/appui/blob/cdf196a5ab3abe1fc6b00f26094639d11df1ca71/package.json#LL33C9-L33C9

raplemie commented 1 year ago

As this is a rush monorepo, the root package is not expected to be a real package with dependency but simply there for warnings. Plus the packages should be autonomus (so you "should" be able to bring the package and test them without having the full monorepo setup, that likely not work though, but that's part of the idea.)