iTwin / appui

Monorepo for iTwin.js AppUi
MIT License
8 stars 2 forks source link

Evaluate exporting functionality from itwin that is currently being used #422

Closed Rock2000 closed 1 year ago

Rock2000 commented 1 year ago

Civil code (and Pineapple code which Civil relies on) have a few cases where they import something that is not exported. We should evaluate if these can be exported officially, or if these apps should change their code. We're trying to support iTwin Studio and this is not allowed in that platform.

The following is a list of these cases:

1) In the civil-frontend package (src\components\TreeNodeWithChildrenRenderer.tsx) the following imports are used: import { ImageRenderer } from "@itwin/components-react/lib/cjs/components-react/common/ImageRenderer"; import { TreeComponentTestId } from "@itwin/components-react/lib/cjs/components-react/tree/TreeComponentTestId"; (There is also a similar import of TreeNodeContent, but it looks like that has now been exported) 2) In Pineapple's @bentley/itwin-common/src/component/colorpickerpopover/ColorPickerPopover.tsx there is: import { Popover } from "@itwin/itwinui-react/cjs/core/utils"; 3) In Pineapple's @bentley/itwin-2d-widget/src/widget/sheet-viewer/SheetViewerToolbar.tsx: import {ToolbarItemsChangedArgs, ToolbarItemsManager} from "@itwin/appui-react/lib/cjs/appui-react/toolbar/ToolbarItemsManager";

raplemie commented 1 year ago

1 is a duplicate of #419, and the requirement are discussed there. 2 is iTwinUi, not AppUI, feel free to file an issue there. 3 Can you describe the usecase for using this? I see that we have 2 hooks that are public and uses this class as an argument, so it might be an oversight that it is not public, I'll check in more depts what this actually does. (as even the current description of ToolbarItemsManager is wrong.

ezmobivietnam commented 1 year ago

Hi @raplemie , Regarding #3, the use case is described at: https://github.com/iTwin/appui/issues/314.

raplemie commented 1 year ago

Ok, if an issue already exists for 1 and 3 then'll close this one and continue on the ones that existed prior.