search

iTwin / appui

Monorepo for iTwin.js AppUi
MIT License
8 stars 2 forks source link

ToolSettings - Empty tool settings message is not changing based on tool selection #442

Closed Emi1yZhang closed 1 year ago

Emi1yZhang commented 1 year ago

To reproduce the issue:

  1. Open any iModel.
  2. Switch to any other frontstage and then switch back to the main one.
  3. Select a tool that doesn't have any tool settings - distance measurement for example.
  4. Notice that empty tool settings message doesn't pick up correct active tool in label and still shows the first one that was selected on iModel open, so in this case it'll always be "Select Elements" tools. image

Possible fix: appui/ui/appui-react/src/appui-react/widget-panels/ToolSettings.tsx at master · iTwin/appui · GitHub Add a callback based on activeToolId to change emptySettings correspondingly to this function.

image

Thank you!

raplemie commented 1 year ago

Thanksk for reporting this, we'll look into it!

raplemie commented 1 year ago

Hi @Emi1yZhang, a fix for this was released today in 4.5.0, please give it a try and let us know if it fixes your issue!