iTwin / appui

Monorepo for iTwin.js AppUi
MIT License
8 stars 2 forks source link

_handleContainerComit is called to commit changed values when `Escape` button is clicked #630

Open rohitnayakbentley opened 6 months ago

rohitnayakbentley commented 6 months ago

Describe the bug _handleContainerComit is called to commit changed values when Escape button is clicked, instead onPressEscape should be called.

To Reproduce Steps to reproduce the behavior:

  1. Click on any property record
  2. Press make some change in property and press escape button,
  3. Then it hits breakpoint at onPressEscape and it removes recently made changes, which is expected.
  4. But if I don’t put breakpoint at onPressEscape, and then press escape button then following code is executed, which ultimately updated property values. [We expect to ignore changes if escape is clicked instead of updating]

Expected behavior Changes from property editor record should not be committed via _handleContainerComit when escape button is clicked. Instead it should just revert changes made and remove focus.

Screenshots image

image

Desktop (please complete the applicable information):

raplemie commented 6 months ago

Thanks, we'll look into this!