search

iTwin / appui

Monorepo for iTwin.js AppUi
MIT License
8 stars 2 forks source link

Open 'pw' scheme links in a new window #860

Closed GerardasB closed 1 month ago

GerardasB commented 1 month ago

Changes

This PR fixes #857 by updating handlers of VirtualizedPropertyGrid and UrlPropertyValueRenderer components to open links with pw scheme in a new window.

Testing

Updated unit tests and added story.

grigasp commented 1 month ago

As far as I remember, mailto and pw schemes were handled differently, because that allowed associated apps to take over the "open" request. I think it needs to be confirmed that a local ProjectWise app still opens the link after the change.

GerardasB commented 1 month ago

As far as I remember, mailto and pw schemes were handled differently, because that allowed associated apps to take over the "open" request. I think it needs to be confirmed that a local ProjectWise app still opens the link after the change.

I've tested this change with the mailto protocol as well and can confirm, that it gets handled correctly.