search

iTwin / appui

Monorepo for iTwin.js AppUi
MIT License
8 stars 2 forks source link

Fix option checks in `useSolarDataProvider()` #956

Open GerardasB opened 1 month ago

GerardasB commented 1 month ago

Describe the bug

Fix !!IModelApp.renderSystem.options.displaySolarShadows checks in useSolarDataProvider(). We can remove this check entirely since it is already checked in wantShadows. Due to the default value, the correct way to check the displaySolarShadows is: false !== IModelApp.renderSystem.options.displaySolarShadows.

Review other usage of renderSystem.options.