mergify[bot]
commented
2 weeks ago Cherry-pick of dba0cd442884bf7dcd02825c2c4faf61302535da has failed:
On branch mergify/bp/release/4.16.x/pr-982
Your branch is up to date with 'origin/release/4.16.x'.
You are currently cherry-picking commit dba0cd442.
(fix conflicts and run "git cherry-pick --continue")
(use "git cherry-pick --skip" to skip this patch)
(use "git cherry-pick --abort" to cancel the cherry-pick operation)
Changes to be committed:
new file: common/changes/@itwin/appui-react/fix_tool_settings_2024-08-26-13-14.json
modified: test-apps/appui-test-app/appui-test-providers/src/tools/SampleTool.ts
modified: test-apps/appui-test-app/appui-test-providers/src/tools/ToolWithDynamicSettings.ts
modified: ui/appui-react/src/appui-react/uiprovider/ComponentGenerator.tsx
modified: ui/appui-react/src/test/frontstage/ModalSettingsStage.test.tsx
Unmerged paths:
(use "git add <file>..." to mark resolution)
both modified: docs/changehistory/NextVersion.md
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Changes
Fixed tool setting property editor not updating state after value is changed. This resulted in editor component always having only initial value and not the current value.
Fixes https://github.com/iTwin/appui/issues/981
Testing
Did manual testing with various tools in standalone test-app. Fixed some tools to correctly update settings values as some of them were changing only in UI.
This is an automatic backport of pull request #982 done by Mergify.