We had no padding on the right side of the SelectionCountField and it looked weird when there was a separator after it (the separator removes padding between different status bar fields). Changes:
I added margins (--iui-size-xs) from both left and right sides now. I chose margins instead of paddings because padding is considered a part of the width so it basically decreased the min-width that we set (more specifically it would decrease the space reserved for more digits).
Changed the min-width from --iui-size-2xl (equivalent to 4rem) to 3.75rem. This slightly decreases the min width of the component and is perfect to fit 5 digits without shifting other status bar content. I made this change because we previously had padding-left which is now switched to margin-left (again, the padding eats into the width and margin does not) so the freed up space was not needed anymore.
Adding some screenshots for comparison. Note that the first two images have separators.
Before:
After:
Fixes #978.
Testing
Tested in test-app.
This is an automatic backport of pull request #979 done by Mergify.
Changes
We had no padding on the right side of the
SelectionCountFieldand it looked weird when there was a separator after it (the separator removes padding between different status bar fields). Changes:--iui-size-xs) from both left and right sides now. I chose margins instead of paddings because padding is considered a part of the width so it basically decreased themin-widththat we set (more specifically it would decrease the space reserved for more digits).min-widthfrom--iui-size-2xl(equivalent to4rem) to3.75rem. This slightly decreases the min width of the component and is perfect to fit 5 digits without shifting other status bar content. I made this change because we previously hadpadding-leftwhich is now switched tomargin-left(again, the padding eats into the width and margin does not) so the freed up space was not needed anymore.Adding some screenshots for comparison. Note that the first two images have separators.
Before:
After:
Fixes #978.
Testing
Tested in test-app.
This is an automatic backport of pull request #979 done by Mergify.