search

iTwin / auth-clients

MIT License
6 stars 3 forks source link

pass metadata to oidc-client-ts #178

Closed paulius-valiunas closed 1 year ago

paulius-valiunas commented 1 year ago

Without this metadata, the client uses fetch to get issuer metadata, which is not always available (especially in older Node.js versions)

paulius-valiunas commented 1 year ago

@aruniverse I see you added usage of AbortController here: https://github.com/iTwin/auth-clients/pull/126/files#diff-043b55e385b562642d1fdd78c8597fa90d2a309cd0497a31d68f6ce57bf4b722R159 Given that this package is supposed to support iTwin.js 3.3.0, I think it should also support Node.js 12.x, which doesn't have that API. Do you think you could make it work without the new API?

aruniverse commented 1 year ago

@aruniverse I see you added usage of AbortController here: #126 (files) Given that this package is supposed to support iTwin.js 3.3.0, I think it should also support Node.js 12.x, which doesn't have that API. Do you think you could make it work without the new API?

Ah good catch. Technically youre right, but considering Node 12 has been EOL for over a year, Im tempted to not fix this, and only do so if someone brings this up