Closed johnnyd710 closed 7 months ago
Looks good, but integration tests are now failing. Could you look into why?
Looks good, but integration tests are now failing. Could you look into why?
The basic.test.t > failure with invalid Bentley federated user
integration test was entering the invalid@bentley.com username twice (another reason not to use type
) and the test was checking for Enter a valid email address, phone number, or Skype name.
which is the incorrect thing to test for.
It should be checking for This username may be incorrect. Make sure you typed it correctly.
for the case of an invalid username but correctly formatted email, like it does now that fill
replaces the input text instead of adding to it.
Now its failing on mac because ErrorResponse: Authorization code is invalid or expired.
?
Now its failing on mac because
ErrorResponse: Authorization code is invalid or expired.
?
Re-running...
Thanks @johnnyd710
Using
locator.fill
is the recommended way to fill out input, andPage.type
is now deprecated.I made these changes using
pnpm patch
for my Electron application, and I think it will close https://github.com/iTwin/auth-clients/issues/224 but I can't be sure because the issue is flaky and doesn't happen frequently.