search

iTwin / bis-schemas

This repository is the single-source-of-truth (SSOT) for all BIS schemas.
https://www.itwinjs.org/bis/
MIT License
12 stars 5 forks source link

StructuralPhysical schema v1.0.0 missing bis:PhysicalType subclasses #67

Open diegoalexdiaz opened 2 years ago

diegoalexdiaz commented 2 years ago

Every concrete bis:PhysicalElement class in the StructuralPhysical schema shall have a corresponding PhysicalType subclass. E.g. Column --> ColumnType, Beam --> BeamType, etc.

NabilSleiman commented 2 years ago

We have the extruded member which can be a column or a beam, should we deprecate that in favor of more specific members?

diegoalexdiaz commented 2 years ago

The StructuralPhysical schema (both versions 1.0.0 and 1.1.0) have several concrete-physical-classes (i.e. classes that can be instantiated). That schema needs to provide corresponding PhysicalType-classes so connectors/iModel-writers can setup the expected PhysicalElement->is of->PhysicalType pattern in BIS.

diegoalexdiaz commented 2 years ago

Per BWG meeting: Add StructuralAssemblyType and StructuralAccessoryType to the types already included in the PR.