iTwin / iTwinUI-layouts

iTwinUI-layouts places given React components accordingly within the page with minimal effort on the development side.
https://itwin.github.io/iTwinUI-layouts
MIT License
6 stars 1 forks source link

Full size screenshot captures only 100vh part of the page, since .iui-layouts-page has strict height set #63

Open irenajur opened 2 years ago

irenajur commented 2 years ago

Environment

Steps to reproduce

Noticed this while trying to get full page screenshot of https://developer.bentley.com homepage. I'm using Chrome for this, but there might be other full screen capturing tools used to reproduce this.

  1. Open https://developer.bentley.com in Chrome browser
  2. Open devtools
  3. Press Ctrl+Shift+p
  4. Select "Capture full size screenshot"

Actual behavior

Currently full size screenshot captures only 100vh page part of the page, since it's limited to 100vh.

developer bentley com_

While for pages that are not using iTwinUI-layout it captures full page. Changing "height" to "min-height" somewhat "fixes" that, but this impacts the sidenav badly, so this might require a deeper look.

.iui-layouts-page {
    min-height: 100vh; //height: 100vh; 
    display: grid;
    grid-template:
        "header header" auto
        "sidenav content" 1fr/auto 1fr;
}
bentleyvk commented 2 years ago

What a strange issue you found here 😀 Hm, it was intended that header and side bar are static and only content is scrollable, so I am not sure how to fix it, need to investigate more, maybe we could do something with :has when it will be supported. But I can't promise that this will be fixed soon.

irenajur commented 2 years ago

What a strange issue you found here 😀 Hm, it was intended that header and side bar are static and only content is scrollable, so I am not sure how to fix it, need to investigate more, maybe we could do something with :has when it will be supported. But I can't promise that this will be fixed soon.

It was more of a strange finding 😄 definitelly not something that breaks anything or requires a quick fix.