search

iTwin / iTwinUI-react

A react component library for iTwinUI.
https://github.com/iTwin/iTwinUI
Other
83 stars 23 forks source link

Error page: image size changes on text change #27

Closed veekeys closed 3 years ago

veekeys commented 3 years ago

Error page image size must be static, now it depends on error text width

mayank99 commented 3 years ago

This is an easy fix. Basically we are using the wrong class in react (should be "illustration" not "icon") https://github.com/iTwin/iTwinUI-react/blob/58aa4fa04236da6d1830fc8ba7b4386f47bf9935/src/core/ErrorPage/ErrorPage.tsx#L114

I believe @FlyersPh9 was working on class renames for non ideal state, so we could wait for that.