search

iTwin / iTwinUI-react

A react component library for iTwinUI.
https://github.com/iTwin/iTwinUI
Other
84 stars 23 forks source link

Select: icon is different than combobox #465

Closed veekeys closed 2 years ago

veekeys commented 2 years ago

ComboBox and Select looks too different. So one or another should be changed to have same arrow icon.

ComboBox: image

Select: image

mayank99 commented 2 years ago

This is a CSS issue as we're not using an SVG in Select. Can be fixed together with https://github.com/iTwin/iTwinUI/issues/395

mayank99 commented 2 years ago

@gretanausedaite Depending on your approach, it might be possible to fix these related issues all together with this one:

That last one is a PR which doesn't have a dedicated issue, but the problem can be summarized as: ComboBox does not support providing an input-container icon (such as an icon in the status message), because it is already using that icon slot for the arrow.

If your solution involves changing the arrow to not rely on the input-container grid, then it will fix all four of these issues together.

mayank99 commented 2 years ago

@veekeys This is released in iTwinUI-react v1.31.0. So you should be able to remove any workarounds you had on your end (e.g. content-box).