search

iTwin / iTwinUI-react

A react component library for iTwinUI.
https://github.com/iTwin/iTwinUI
Other
83 stars 23 forks source link

Table: `isDisabled` prop appearing in the DOM #654

Closed mayank99 closed 2 years ago

mayank99 commented 2 years ago

Noticed this error while running tests.

Warning: React does not recognize the isDisabled prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase 'isdisabled' instead.

Doesn't break anything but is likely unintentional.

bentleyvk commented 2 years ago

Fixed in https://github.com/iTwin/iTwinUI-react/pull/648/files#diff-6598fb1840e015668ee4a347bcc666df67450bd76d01f8e21c5064b101984355R51

mayank99 commented 2 years ago

Fixed in #648 (files)

Instead of isDisabled;, would it be better to just add eslint-disable-line when destructuring from the prop?