feat!: Update itwinui-css to 1.0.0.dev.10

iTwin / iTwinUI-react

A react component library for iTwinUI.

https://github.com/iTwin/iTwinUI

Other

84 stars 23 forks source link

feat!: Update itwinui-css to 1.0.0.dev.10 #733

Closed veekeys closed 2 years ago

veekeys commented 2 years ago

Updated css import for build to pass

Todo:

[x] Alert https://github.com/iTwin/iTwinUI/pull/639#issuecomment-1148553848
[ ] Inputs revalidate multiple imports https://github.com/iTwin/iTwinUI/pull/639#issuecomment-1148553848
[ ] Validate all the visual changes with updating test images
Alert: Class name & specificity refactor commit
- iui-button iui-borderless iui-small -> iui-alert-button
- iui-button-icon -> iui-alert-button-icon
- iui-alert iui-informational -> iui-alert-informational (same with all the statuses)

adamhock commented 2 years ago

#749 Table Refactor

Data Attribute
- iui-condensed/extra-condensed replaced with data-iui-size="condensed/extra-condensed"
- iui-selected replaced with aria-selected="true"
- iui-table-body elements that contain selectable rows now have aria-multiselectable="true"
- iui-disabled replaced with aria-disabled="true"
Class name changes
- iui-paginator-* changed to iui-table-paginator-*
- iui-column-filter changed to iui-table-column-filter
- iui-filter-button changed to iui-table-filter-button
- iui-resizer-* changed to iui-table-resizer-*
- iui-sort changed to iui-table-sort
- iui-reorder-bar-* changed to iui-table-reorder-bar-*
- iui-expanded-content changed to iui-table-expanded-content
- iui-row-* changed to iui-table-row-*
- iui-cell-* changed to iui-table-cell-*

veekeys commented 2 years ago

Tasks with current css dev package

[x] Header (Adam)
[x] Wizard (Adam)
[x] UserIcon
[ ] RadioTileGroup

mayank99 commented 2 years ago

After updating this branch, some of the tests are failing. Whoever worked on and/or reviewed the recently merged PRs (e.g. #776, #737, #810, #811, etc) should update the tests to pass. @iTwin/itwinui-react-1 @iTwin/itwinui-react-2

mayank99 commented 2 years ago

@rohan-kadkol You need to resolve merge conflicts in this PR that are resulting from your shift-click changes.

r100-stack commented 2 years ago

@rohan-kadkol You need to resolve merge conflicts in this PR that are resulting from your shift-click changes.

Fixed the three files that had merge conflicts:

For the two Dialog related images (first two files), I just chose the version on the main branch

For Table.test.tsx (3rd file), I fixed it by:

Changing selected state checks from class name should have .iui-selected to should have attribute aria-selected = true
Added shift click tests checks