search

iTwin / iTwinUI-react

A react component library for iTwinUI.
https://github.com/iTwin/iTwinUI
Other
84 stars 23 forks source link

Shift selection ignores any ctrl/checkbox/toggle selections in multi selection mode table #879

Closed ainepi closed 1 year ago

ainepi commented 2 years ago

Describe the bug (actual behavior)

When using multi selection mode table, clicking more than one item (using ctrl or checkbox), and then using shift selection, it ignores any other selected items and takes the first selected item as a starting point for the shift range. image

Expected behavior

Shift should take the last selected item as a starting point for range selection

Steps to reproduce
  1. Select any row
  2. Select a second row using the checkbox or ctrl
  3. Use shift to select any row
Additional information

Related issue #880

r100-stack commented 2 years ago

Hi @ainepi, I made a PR #886 for your Ctrl + Shift click issue #880. For this issue, I made a commit on the rohan/table-shift-click-checkbox-bug branch. This is not complete but I think it implements a majority of the fix.

I could make a PR from that branch to main, or if you feel like it, you can make your own PR, possibly using my branch for ideas. (We encourage external contributions :slightly_smiling_face:). Please let me know what you prefer.

r100-stack commented 2 years ago

@ainepi As we discussed via chat, I made PR #889. Feel free to comment on that PR if you have any comments/suggestions.