feat(Table): Ctrl + Shift click keeps previous selection & also shift clicks

r100-stack commented 2 years ago

[CONTINUES] PR #886 (closed as it was pointing to main and not v2). Pointing this to v2 to avoid delaying v2 due to merge conflicts with main.

Closes #880

Shift click keeps previous selection when holding Ctrl when Shift clicking

NOTE: The related issue #879 about lastSelectedRowId not updating on checkbox click, will come in a separate PR, hopefully from the external contributor. After that PR, this Ctrl + Shift functionality can be completely realized.

Screenshots

Steps

Click 1.1
Shift click 1.2.2
Ctrl click 2.1 and 2.3
Ctrl + Shift click 1.2.4

New

Previous selection of 2.1 and 2.3 is preserved

vokoscreenNG-2022-10-18_16-33-25.webm

Old

Previous selection of 2.1 and 2.3 is lost

vokoscreenNG-2022-10-18_16-41-20.webm

Checklist

[x] Add meaningful unit tests for your component (verify that all lines are covered)
[x] Verify that all existing tests pass
~[ ]~ Add component features demo in Storybook (different stories)
~[ ]~ Approve test images for new stories
[x] Add screenshots of the key elements of the component

GintV commented 1 year ago

What's the progress on this one? When we could expect this to get released? Will this be included only in 2.x?

cc @ainepi

mayank99 commented 1 year ago

What's the progress on this one? When we could expect this to get released? Will this be included only in 2.x?

cc @ainepi

We put this one on hold to release 2.0, I expect we'll get back to this very soon. I think we would only release it in 2.x.

r100-stack commented 1 year ago

@mayank99 @adamhock There were many merge conflicts in Table.test.tsx (since main also included table test cases from PR #889). So I had to manually update the tests to includes test cases from PR #889 and this PR.

Since I updated Table.test.tsx quite a bit, I think it would be safer if you could take a quick look at Table.test.tsx and re-approve it.

iTwin / iTwinUI-react