chore: Update to using itwinui-css 1.0.0-dev.10 - Githubissues

iTwin / iTwinUI-react

A react component library for iTwinUI.

https://github.com/iTwin/iTwinUI

Other

83 stars 23 forks source link

chore: Update to using itwinui-css 1.0.0-dev.10 #890

Closed r100-stack closed 1 year ago

r100-stack commented 1 year ago

@rohan-kadkol This still needs a CSS fix, as we can't expect users to always provide the fill as an inline style.

Sorry, I saw two approvals after my push, so I merged. Maybe next time I'll wait a little longer just to confirm everything is alright.

I will work on that CSS change. When confirming that CSS change in react, I will undo the inline style changes from this commit.

Originally posted by @rohan-kadkol in https://github.com/iTwin/iTwinUI-react/issues/881#issuecomment-1281069716

Implements v1 (issue #831) CSS change: fix(Table): Changing start icon fill from tag
Undoes the inline style fill changes mentioned in the above-quoted comment

Checklist

~[ ]~ Add meaningful unit tests for your component (verify that all lines are covered)
[x] Verify that all existing tests pass
~[ ]~ Add component features demo in Storybook (different stories)
~[ ]~ Approve test images for new stories
~[ ]~ Add screenshots of the key elements of the component