iTwin / iTwinUI-react

A react component library for iTwinUI.
https://github.com/iTwin/iTwinUI
Other
84 stars 23 forks source link

feat(Wizard): Deprecate `Wizard` to use `Stepper`/`WorkflowDiagram` #905

Closed r100-stack closed 1 year ago

r100-stack commented 1 year ago
  • Rename components that have changed in css v1
    • e.g. Avatar (Rohan PR #902), Stepper (Rohan)
    • Deprecate old names while pointing them to new ones

From https://github.com/iTwin/iTwinUI-react/issues/849


Checklist

r100-stack commented 1 year ago

It would be easier to tell if the tests have changed if they're 'renamed' vs deleted and created again.

Good idea. Changed the test image git changes to "rename" type changes instead of "delete and add" changes. I then re-ran yarn test to catch any image changes.

Did you run the visual tests and then clean them after you updated the images?

Yes, I ran yarn test. The old Wizard test images are removed (renamed to Stepper/WorkflowDiagram)

elephantcatdog commented 1 year ago

Good idea. Changed the test image git changes to "rename" type changes instead of "delete and add" changes. I then re-ran yarn test to catch any image changes.

Thank you, this is great!

Yes, I ran yarn test. The old Wizard test images are removed (renamed to Stepper/WorkflowDiagram)

Hm, I was pretty sure that you have to run yarn clean? image

~I'm mostly asking because I don't see a removed file for Wizard.test.ts-WorkflowDiagram.png.~

Update: Nevermind, I see that it was renamed. Looks good then!