Closed r100-stack closed 1 year ago
It would be easier to tell if the tests have changed if they're 'renamed' vs deleted and created again.
Good idea. Changed the test image git changes to "rename" type changes instead of "delete and add" changes. I then re-ran yarn test
to catch any image changes.
Did you run the visual tests and then clean them after you updated the images?
Yes, I ran yarn test
. The old Wizard
test images are removed (renamed to Stepper
/WorkflowDiagram
)
Good idea. Changed the test image git changes to "rename" type changes instead of "delete and add" changes. I then re-ran yarn test to catch any image changes.
Thank you, this is great!
Yes, I ran yarn test. The old Wizard test images are removed (renamed to Stepper/WorkflowDiagram)
Hm, I was pretty sure that you have to run yarn clean
?
~I'm mostly asking because I don't see a removed file for Wizard.test.ts-WorkflowDiagram.png
.~
Update: Nevermind, I see that it was renamed. Looks good then!
From https://github.com/iTwin/iTwinUI-react/issues/849
Wizard
but not delete itUserIcon
->Avatar
(PR #902).Stepper
when Wizard.type =default
|long
, andWorkflowDiagram
when Wizard.type =workflow
Wizard = Stepper
is not possibleStepper
andWorkflowDiagram
Checklist