search

iTwin / iTwinUI-react

A react component library for iTwinUI.
https://github.com/iTwin/iTwinUI
Other
83 stars 23 forks source link

Update codesandboxes with the latest changes #948

Closed gretanausedaite closed 1 year ago

gretanausedaite commented 1 year ago

Update code sandbox examples with react v2

image
mayank99 commented 1 year ago

I think @veekeys owns the codesandbox we currently use. Thinking from a maintainability perspective, we should probably have the code for the sandbox be inside our repo (kinda like how we want to add examples in #929). Codesandbox and Stackblitz both support using github as a source.

Currently if you try to use the vite playground as a source, it fails because it relies on private deps (configs) in the monorepo. We shouldn't really rely on that tsconfig because it's meant for our package, not for playgrounds or examples (which should be standalone imo).

Once we do that, we would just need to update the links in our README and issue templates.

veekeys commented 1 year ago

As for now, I fixed the compilation issue. Check up if need to change something else.

mayank99 commented 1 year ago

As for now, I fixed the compilation issue. Check up if need to change something else.

The @import '@itwin/itwinui-variables' at the top of styles.scss is not needed because variables are already imported by useTheme. Other than that looks good, thanks!

veekeys commented 1 year ago

Updated. I guess you can close this and update other issue with support of playground compilation in cloud.