search

iTwin / iTwinUI-react

A react component library for iTwinUI.
https://github.com/iTwin/iTwinUI
Other
83 stars 23 forks source link

ComboBox: broken layout when using virtualization #984

Closed mayank99 closed 1 year ago

mayank99 commented 1 year ago

In v2, combobox with enableVirtualization looks broken. The menu takes up all the available height and doesn't scroll properly.

https://itwin.github.io/iTwinUI-react/?path=/story/core-combobox--virtualized https://itwin.github.io/iTwinUI-react/iframe.html?args=&id=core-combobox--virtualized&viewMode=story

bentleyvk commented 1 year ago

How visual tests then passed?

mayank99 commented 1 year ago

apparently we don't test the virtualized combobox 😆

https://github.com/iTwin/iTwinUI-react/blob/21900d42900f7a03305bf2040cc64ddb29361b2d/apps/storybook/src/ComboBox.test.ts#L7-L16

mayank99 commented 1 year ago

Fixed in #986, released in @itwin/itwinui-react@2.0.3 🎉