search

iTwin / iTwinUI

A design system for building beautiful and well-working web interfaces.
https://itwin.github.io/iTwinUI/
MIT License
105 stars 38 forks source link

Evaluate exporting functionality from itwinui that is currently being used by civil #1429

Closed Rock2000 closed 1 year ago

Rock2000 commented 1 year ago

Pineapple code, which Civil relies on, has a case where they import something that is not exported. We should evaluate if these can be exported officially, or if these apps should change their code. We're trying to support iTwin Studio and these deep imports are not allowed in that platform.

In Pineapple's @bentley/itwin-common/src/component/colorpickerpopover/ColorPickerPopover.tsx there is: import { Popover } from "@itwin/itwinui-react/cjs/core/utils";

mayank99 commented 1 year ago

Pineapple should get rid of that import. It is an internal utility not meant to be used publicly.