iTwin / iTwinUI

A design system for building beautiful and well-working web interfaces.
https://itwin.github.io/iTwinUI/
MIT License
92 stars 35 forks source link

Draggable `Dialog` does not automatically resize well #1961

Closed HaveSpacesuit closed 2 weeks ago

HaveSpacesuit commented 1 month ago

Describe the bug (current behavior)

Using a dialog with isDraggable, an input element with a validation error causes a scrollbar to appear. Non-draggable dialogs resize to accommodate the status message, but a draggable dialog does not adjust its vertical height.

Draggable dialog height

Expected Behavior

Would be nice to have draggable dialogs adjust their height when their contents change, same as other dialogs.

Link to minimal repro

https://stackblitz.com/edit/github-xnmtqx?file=src%2FApp.tsx

Steps To Reproduce

Anything else?

Using 3.5.0

mayank99 commented 1 month ago

It looks like we measure the initial size of the dialog and duplicate it into inline styles.

mayank99 commented 2 weeks ago

fixed in 3.9.0 🚀