iTwin / iTwinUI

A design system for building beautiful and well-working web interfaces.
https://itwin.github.io/iTwinUI/
MIT License
92 stars 35 forks source link

`Table` layout regression in 3.6 #1965

Closed HaveSpacesuit closed 1 month ago

HaveSpacesuit commented 1 month ago

Describe the bug (current behavior)

Table cells which composed multiple elements would align horizontally prior to iTwinUI-React 3.6. After updating to 3.6 or 3.7, they are now aligning vertically.

3.5 table https://stackblitz.com/edit/github-qken3j-ykcnfs?file=src%2FmyTable.tsx image

3.7 table https://stackblitz.com/edit/github-qken3j?file=src%2FmyTable.tsx image

Expected Behavior

The layout should remain the same as 3.5 and before, with a horizontal alignment.

Link to minimal repro

https://stackblitz.com/edit/github-qken3j?file=src%2FmyTable.tsx

Steps To Reproduce

Anything else?

No response

mayank99 commented 1 month ago

We'll fix the regression, but you should be using cellRenderer+DefaultCell for this use case. https://stackblitz.com/edit/github-qken3j-ehgxs1?file=src%2FmyTable.tsx%3AL15

mayank99 commented 1 month ago

This is fixed in 3.8.0 🥳