iTwin / iTwinUI

A design system for building beautiful and well-working web interfaces.
https://itwin.github.io/iTwinUI/
MIT License
105 stars 38 forks source link

[V1] Icon refactor #606

Closed veekeys closed 2 years ago

veekeys commented 2 years ago
mayank99 commented 2 years ago

To expand, I was thinking three things:

  1. All our svgs in @itwin/itwinui-icons should come with width, height, and fill attributes. This would mean we have to write less CSS.
  2. All the icons in @itwin/itwinui-icons-elements should have a way to target them with a common selector. This could be a data attribute, e.g. data-iui-icon=true, or even add the name of the icon: data-iui-icon=calendar
  3. Assuming those changes are made in the icons packages, in @itwin/itwinui-css we could target all web components with [data-iui-icon] and apply any special styles, e.g. display: flex.