Dialog CSS needs updates - Githubissues

iTwin / iTwinUI

A design system for building beautiful and well-working web interfaces.

https://itwin.github.io/iTwinUI/

MIT License

106 stars 38 forks source link

Dialog CSS needs updates #759

Closed mayank99 closed 2 years ago

mayank99 commented 2 years ago

Between draggable dialog and dialog wrapper, there are a bunch of incorrect/redundant styles that need to be changed in itwinui-css.

Two main changes:

dialog-wrapper should have position: fixed or position: absolute. Currently it has position: relative.
draggable dialog should not have any position or sizing styles, because position will be set in JS and size should come from the default dialog.

_Originally posted in https://github.com/iTwin/iTwinUI-react/pull/771#discussion_r962015453_

bentleyvk commented 2 years ago

Also need to remove overflow: hidden from iui-dialog https://github.com/iTwin/iTwinUI-react/pull/823#discussion_r968440623