Transformer doesn't prune unused geometry part references

iTwin / imodel-transformer

API for exporting an iModel's parts and also importing them into another iModel

MIT License

3 stars 2 forks source link

Transformer doesn't prune unused geometry part references #114

Open MichaelBelousov opened 10 months ago

MichaelBelousov commented 10 months ago

Files transformed by the transformer often keep huge unused definition elements like geometry parts. We need to track references to geometry parts (in geometry streams, line symbols, pattern symbols) while cloning geometry to prevent this.

Users facing this now must use the IModelDb.elementGeometryRequest API to check for used geometry parts themselves, and not import them, but the transformer should start doing this in its own native geometry cloning routine.

timlawrence-bentley commented 10 months ago

Hi Michael, is there an estimate on when this fix will be available? This has come up as a paid prod issue labeled as high priority and the client has been asking about this. Thanks, Tim

MichaelBelousov commented 10 months ago

Hi Michael, is there an estimate on when this fix will be available? This has come up as a paid prod issue labeled as high priority and the client has been asking about this. Thanks, Tim

The estimate I gave when I was asked monday was 3-4 weeks. Please contact me if you think that is an issue.

MichaelBelousov commented 10 months ago

Going to fix this in 2 phases:

temporary internal fix prunes geometry after transformation, https://github.com/iTwin/imodel-transformer/pull/115, deployed for testing as @itwin/imodel-transformer@0.3.3-prune-geom-parts.0
longer term fix rewrite native geometry processing to record references as it goes, which will go hand-in-hand with the refactor of all native geometry processing