iTwin / imodel-transformer

API for exporting an iModel's parts and also importing them into another iModel
MIT License
3 stars 2 forks source link

skipPropagateChangesToRootElements should be default true #177

Closed nick4598 closed 1 week ago

nick4598 commented 2 months ago

Transformation services has hit 2 issues with the 'skipPropagateChangesToRootElements' being defaulted to false so far.

Might be worth bringing this up with the larger group as well

JulijaRamoskiene commented 2 months ago

Suggest to also update documentation with information that iModel name will be updated when skipPropagateChangesToRootElements is set to false: image

nick4598 commented 2 months ago

Agree its worth mentioning, thanks.

This is caused by calling initializeiModelDb after we pushChanges. initializeiModelDb updates the .name property on the iModelDb by setting it to the name of the rootsubject. Since changes to root elements are being propagated, that root subject name gets changed and leads to the iModelDb.name property being updated.