iTwin / imodel-transformer

API for exporting an iModel's parts and also importing them into another iModel
MIT License
3 stars 2 forks source link

Remove unbounded cache sizes #83

Open MichaelBelousov opened 1 year ago

MichaelBelousov commented 1 year ago

Unbounded caches in use are problematic:

Proposed changes:

Short term solutions:

MichaelBelousov commented 1 year ago

worth noting, last time I tried using the integer based map in iTwin.js core for the transformer, it worsened performance 5-10% iirc. We need an integer based map though to do a naive run-compressed map. So need to think about this.

MichaelBelousov commented 11 months ago

this is done partially in the early-polymorphic-insert branch

EDIT: that branch now includes a CompactRemapTable class which does this remapping entirely

MichaelBelousov commented 8 months ago

the federation-guid-optimization branch also adds a new source changes cache which is unbounded