search

iTwin / imodels-clients

Monorepo for iModels API clients
MIT License
6 stars 2 forks source link

Add allowpreceding support #149

Closed nick4598 closed 1 year ago

austeja-bentley commented 1 year ago

I think we could merge this but the build validation seems to fail: image

nick4598 commented 1 year ago

I think we could merge this but the build validation seems to fail: image

I changed it to null comparison instead

austeja-bentley commented 1 year ago

One more question - are these changes tested, especially the findLatestV2CheckpointForChangeset function (at least manually)?

nick4598 commented 1 year ago

One more question - are these changes tested, especially the findLatestV2CheckpointForChangeset function (at least manually)?

I haven't tested. Do you know of an iModel, especially one that has a v1 checkpoint without a v2 checkpoint? It would be nice to see us skip over that v1 and still find that preceding v2. Or maybe we could make one somehow, maybe start v2ca and kill it before it finishes in dev.