search

iTwin / imodels-clients

Monorepo for iModels API clients
MIT License
6 stars 2 forks source link

Run a wal checkpoint on iModel if wal file is present when uploading it. #204

Closed nick4598 closed 10 months ago

nick4598 commented 10 months ago

This PR includes a change to copy the baseline file to the tempdir as opposed to the IModelHost.cacheDir. Seems more fitting since this file gets deleted immediately after. From Keith: "The cache directory is used for information that should be preserved across runs of the program (e.g. briefcases). The temp directory is specific to a backend instance and is often on another less-secure drive."

The test I added initially took 20 seconds mostly due to the busy handler, but I decided to comment out the part that checks for the database is locked error and just leave it as a note.

nick4598 commented 10 months ago

Tests failing, but unsure why.. seem unrelated to my changes but could be wrong. I can't debug locally at the moment, either due to missing env files or outdated ones. @austeja-bentley if you could assist me next week on getting the tests running locally that would be much appreciated.

austeja-bentley commented 10 months ago

Tests failing, but unsure why.. seem unrelated to my changes but could be wrong. I can't debug locally at the moment, either due to missing env files or outdated ones. @austeja-bentley if you could assist me next week on getting the tests running locally that would be much appreciated.

@nick4598 Thanks for letting me know, I just merged a PR with integration test fixes. Please pull the latest changes from the main branch